Multi target support #653

adnull · 2023-05-07T17:29:15Z

This is multi-target support implementation of the mongodb_exporter. This version can be used with prometheus to allow scraping multiple hosts metrics by running just single instance of the exporter.

The code contains minimal changes to implement this feature and doesn't conflict with the main branch.
Multiple targets can be specified in the mongodb.uri option as comma separated list of server URIs
Also, a new option was added - mongodb.connect-timeout-ms which sets default server connection timeout.
Usage notes are located in the readme file in my fork https://github.com/adnull/mongodb_exporter_mt

Tests passed.
Fix conflicts with target branch.

percona#639) Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.47.3 to 1.52.2. - [Release notes](https://github.com/golangci/golangci-lint/releases) - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md) - [Commits](golangci/golangci-lint@v1.47.3...v1.52.2) --- updated-dependencies: - dependency-name: github.com/golangci/golangci-lint dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

percona#665) Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.52.2 to 1.53.2. - [Release notes](https://github.com/golangci/golangci-lint/releases) - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md) - [Commits](golangci/golangci-lint@v1.52.2...v1.53.2) --- updated-dependencies: - dependency-name: github.com/golangci/golangci-lint dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Remove prometheus/client_golang replace * Apply formater * Downgrade client_golang to previous version * Upgrade exporter-toolkit to v0.10.0

adnull · 2023-08-04T08:59:03Z

@JiriCtvrtka Hi! Seems like there are problems with the test-cluster. I've checked all tests on my local machine and they are failing like this only if test-cluster didn't set up properly.
For example, this error:

    testutils.go:135:
        	Error Trace:	/Users/user/projects/mongodb_exporter/internal/tu/testutils.go:135
        	Error:      	Received unexpected error:
        	            	server selection error: context deadline exceeded, current topology: { Type: Single, Servers: [{ Addr: 127.0.0.1:17001, Type: Unknown, Last error: dial tcp 127.0.0.1:17001: connect: connection refused }, ] }

means that node mongo-1-1 is down.
Probably it is not enough disk space to run cluster. Or it needs a little bit more time to come up before running tests.

JiriCtvrtka · 2023-08-04T09:11:21Z

@adnull Hi. Yes I am on it. I also noticed some minor problems in exporter (not in your PR). I will merge this once since it will be fixed. Thank you for your PR and efford.

BupycHuk

A few minor comments.
Once PR with test fixes is merged we will check that tests are not failed and merge this PR. As far as I see there are no backward incompatible changes.

exporter/exporter.go

exporter/server.go

main.go

Co-authored-by: Nurlan Moldomurov <[email protected]>

BupycHuk · 2023-10-10T09:08:33Z

@adnull please fix the linter
@JiriCtvrtka PTAL

adnull · 2023-10-10T09:43:41Z

@adnull please fix the linter

Sure, forgot to format. done.

BupycHuk · 2023-10-10T11:32:25Z

@adnull, linters are still complaining. Please address them.

adnull · 2023-10-10T11:48:12Z

@adnull, linters are still complaining. Please address them.

Sure, i am looking into it and can't get why they fail with the errors like tagalign and nlreturn on the code which is no different from the main code while the same actions in my own repository finish successfully.

BupycHuk · 2023-10-11T07:51:41Z

@adnull Seems like your changes wasn't related to linter complains. They existed before, but because you changed those lines linter started complaining. So I merged as is.

adnull · 2023-10-11T10:06:15Z

Oh, they almost broke my mind :) Seems like linters list should be adjusted...

Swoods3 · 2024-01-16T19:42:55Z

Splitting mongodb_uri with commas and within a double quote for example: "mongodb:connection_string" is no longer acceptable. Is there a way to make the config file backwards compatible as it is for versions 0.0.4 to 3.0.1?

Current target is a single cluster multi port as defined by Atlas to monitor and has been working for the last year ENCLOSED in double quotes and has comma separated the 3 target cluster ports as the teams use to connect to the atlas and has been working, but no longer works with version 3.1.0. Here is an example that used to work:

mongodb_uri: "mongodb://user:[email protected]:20000,nameN.mongodb.net:20001,nameN.mongodb.net:20002/dbname-qa?authSource=admin&replicaSet=name&ssl=true&retryWrites=true&w=majority"

adnull · 2024-01-16T20:57:30Z

Splitting mongodb_uri with commas and within a double quote for example: "mongodb:connection_string" is no longer acceptable. Is there a way to make the config file backwards compatible as it is for versions 0.0.4 to 3.0.1?

I've got the idea and will take a look shortly

Swoods3 · 2024-01-16T21:54:10Z

Thanks so much!

…

On Tue, Jan 16, 2024 at 3:57 PM Alex ***@***.***> wrote: Splitting mongodb_uri with commas and within a double quote for example: "mongodb:connection_string" is no longer acceptable. Is there a way to make the config file backwards compatible as it is for versions 0.0.4 to 3.0.1? I've got the idea and will take a look shortly — Reply to this email directly, view it on GitHub <#653 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BDCKWXIHBRPWE7ZZFAWNINLYO3SULAVCNFSM6AAAAAAXZAPLH6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJUGUYDAOBXGU> . You are receiving this because you commented.Message ID: ***@***.***>

-- Shamika Woods Technical Account Manager ***@***.***

adnull · 2024-01-17T13:31:02Z

@Swoods3 i've created a pull-request (#780) regarding the problem you've described. But while it is being waited to be approved and included to a release you can use manually compiled code from the branch or try using my docker image with this feature included: https://hub.docker.com/r/adnull/mongodb_exporter

Swoods3 · 2024-01-17T14:42:53Z

@adnull Thanks so much!

adnull added 6 commits February 13, 2023 23:54

added multi target feature

152b71a

Merge branch 'percona:main' into multi-target

d3e5b24

Merge branch 'percona:main' into multi-target

7342ce9

added connect timeout opts

da9afc3

added tests

4e861b6

fixed test

b7c58c3

adnull requested a review from a team as a code owner May 7, 2023 17:29

adnull requested review from tshcherban and IuriiMr and removed request for a team May 7, 2023 17:29

adnull added 2 commits May 8, 2023 18:23

Merge branch 'main' into multi-target

0ac7892

Merge branch 'main' into multi-target

c5d2b67

adnull mentioned this pull request May 22, 2023

Multi-Target Support #659

Closed

adnull and others added 12 commits May 30, 2023 15:32

Merge branch 'main' into multi-target

f7195cf

Merge branch 'main' into multi-target

562f57c

Merge branch 'main' into multi-target

76a8126

fixed dockerfile

c8cadf1

Merge branch 'main' into multi-target

83dd752

Remove prometheus/client_golang replace (percona#682)

89d0a7e

* Remove prometheus/client_golang replace * Apply formater * Downgrade client_golang to previous version * Upgrade exporter-toolkit to v0.10.0

added multi target feature

4f1d85e

added connect timeout opts

065a847

Merge remote-tracking branch 'upstream/main' into multi-target

13571dc

fixed connect

4a01d30

adnull force-pushed the multi-target branch from d946764 to 4a01d30 Compare July 6, 2023 12:27

JiriCtvrtka and others added 2 commits August 3, 2023 12:46

Merge branch 'main' into multi-target

fa47514

formatted code

3241789

adnull added 5 commits September 23, 2023 20:25

Resolved conflicts with the main branch

cda1aa2

Update README.md

4dc883a

Update README.md

b00d3cd

updated license

44ec283

Merge branch 'main' into multi-target

6a62697

BupycHuk approved these changes Oct 8, 2023

View reviewed changes

exporter/exporter.go Outdated Show resolved Hide resolved

exporter/server.go Outdated Show resolved Hide resolved

main.go Outdated Show resolved Hide resolved

adnull and others added 3 commits October 8, 2023 17:48

Update exporter/server.go

88f5c89

Co-authored-by: Nurlan Moldomurov <[email protected]>

fixed according to review

c341b2a

Merge branch 'main' into multi-target

9e1e0a0

formatted the code

8dc058e

JiriCtvrtka approved these changes Oct 10, 2023

View reviewed changes

adnull added 2 commits October 10, 2023 16:08

minor changes according to the linters

9573d80

Merge branch 'main' into multi-target

df09248

BupycHuk merged commit e02fe4f into percona:main Oct 10, 2023
5 of 6 checks passed

janweinkauff mentioned this pull request Nov 22, 2023

Release v0.40.0 #747

Closed

BupycHuk mentioned this pull request Dec 7, 2023

Fix mongodb_up not set when instance is down #624

Closed

4 tasks

adnull mentioned this pull request Jan 17, 2024

Fix splitting cluster URI into multiple targets #780

Merged

1 task

This was referenced May 29, 2024

mongodb_up metric is not reflecting correctly #347

Closed

mongodb_exporter 0.32.0 could not get response when mongodb instance is down #483

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Multi target support #653

Multi target support #653

adnull commented May 7, 2023 •

edited

Loading

adnull commented Aug 4, 2023 •

edited

Loading

JiriCtvrtka commented Aug 4, 2023

BupycHuk left a comment

BupycHuk commented Oct 10, 2023

adnull commented Oct 10, 2023 •

edited

Loading

BupycHuk commented Oct 10, 2023

adnull commented Oct 10, 2023

BupycHuk commented Oct 11, 2023

adnull commented Oct 11, 2023

Swoods3 commented Jan 16, 2024

adnull commented Jan 16, 2024

Swoods3 commented Jan 16, 2024 via email

adnull commented Jan 17, 2024

Swoods3 commented Jan 17, 2024

Multi target support #653

Multi target support #653

Conversation

adnull commented May 7, 2023 • edited Loading

adnull commented Aug 4, 2023 • edited Loading

JiriCtvrtka commented Aug 4, 2023

BupycHuk left a comment

Choose a reason for hiding this comment

BupycHuk commented Oct 10, 2023

adnull commented Oct 10, 2023 • edited Loading

BupycHuk commented Oct 10, 2023

adnull commented Oct 10, 2023

BupycHuk commented Oct 11, 2023

adnull commented Oct 11, 2023

Swoods3 commented Jan 16, 2024

adnull commented Jan 16, 2024

Swoods3 commented Jan 16, 2024 via email

adnull commented Jan 17, 2024

Swoods3 commented Jan 17, 2024

adnull commented May 7, 2023 •

edited

Loading

adnull commented Aug 4, 2023 •

edited

Loading

adnull commented Oct 10, 2023 •

edited

Loading